Enhancement/issue 354 restore optimization config for no bundle #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
enhancement
5 tasks
thescientist13
added
the
website
This was referenced Mar 14, 2021
thescientist13
force-pushed
the
enhancement/issue-354-restore-optimization-for-no-bundle
branch
from
1be7c07
to
aafb10f
Compare
thescientist13
force-pushed
the
enhancement/issue-354-restore-optimization-for-no-bundle
branch
from
e95afbd
to
0621247
Compare
This was referenced Mar 28, 2021
thescientist13
deleted the
enhancement/issue-354-restore-optimization-for-no-bundle
branch
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* client side router optimization setting for build * filter only for anchor tags * preserve URL on route change * mode vs optimization configuration * test cases for MPA * clean up merge conflict marker * clarify test it statements * fix bug with graphql head tag closing * default optimization for preloading CSS * only preload CSS * add none optimization option * all anticipated optimization settings * simplify minified output check * added static optimization setting for JS templating * introduce inline optimization setting * inline optimization support enhancements * fix styling for tables * documentation for mode and optimization * use modulepreload for ESM script tags
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* client side router optimization setting for build * filter only for anchor tags * preserve URL on route change * mode vs optimization configuration * test cases for MPA * clean up merge conflict marker * clarify test it statements * fix bug with graphql head tag closing * default optimization for preloading CSS * only preload CSS * add none optimization option * all anticipated optimization settings * simplify minified output check * added static optimization setting for JS templating * introduce inline optimization setting * inline optimization support enhancements * fix styling for tables * documentation for mode and optimization * use modulepreload for ESM script tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #354
Current Next
Current Production
Summary of Changes
modesetting, now used for overall build context, e.g.mpavsssgvsspa(optimization will be mainly used to handle your<script>/<link>tag features, like inlining or preloading)optimizationconfiguration setting with the default beingdefault'mpa'mode option (fka.'spa') for the websitemode === 'mpa'<head>tagnoneandinlineTODOs
'mpa'get handle bare imports in HTML <script> tags when running build command #434 mergedhave URL change in browserfilter router event handling to only<a>tagsrefactor to have router at@greenwood/router/routecaching (nice to have)<head>tags (<meta>/<title>/<script>/ etc) update when usingstaticRouter#306 will still need a solution, so can move into next project for nowdefaultoptimization setting'none'optimization option'static'(fka.strict) optimization option (see thoughts section below)'inline'optimization inline (see thoughts section below)Thoughts / Next Steps tracking
inline. Will create a preview PR to show off since even locally was getting a 92 with it on!modesetting (at least by default). Not all scripts are created equally,preloadvsprefetch. Router and GraphQL should probably useprefetch. - added to roadmap to 1.0 section in Roadmap To 1.0 And Beyond #418 for tracking<link>/<script>overrides forinlineandstaticoptimization settings - - added to roadmap to 1.0 section in Roadmap To 1.0 And Beyond #418 for tracking<link>/<script>overrides for preload or prefetch hints - - added to roadmap to 1.0 section in Roadmap To 1.0 And Beyond #418 for tracking<routesfor all pages. Saved a WIP branch here and will track as a follow up discussion. - added to roadmap to 1.0 section in Roadmap To 1.0 And Beyond #418 for tracking